-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Make docs live for 5.23 #4689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Make docs live for 5.23 #4689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update release process
- `conda create -n plotly-dev python` currently gives Python 3.12.3. - `pytest -v packages/python/plotly/plotly/tests/` then fails with `ModuleNotFoundError: No module named 'imp'`. - `pip install imp` fails: the `imp` module was deprecated in Python 3.11 and has been removed in Python 3.12. - So update `contributing.md` to specify `conda create -n plotly-dev python=3.11` - But now `pytest` fails - `File "<frozen importlib._bootstrap>", line 1072, in _find_spec` - `AttributeError: 'AssertionRewritingHook' object has no attribute 'find_spec'` - Problem was `pytest==3.5.1` in `packages/python/plotly/optional-requirements.txt` - Update to `pytest==8.1.1` and `pytest` runs - Some tests are failing (orca problems, `statsmodels` not installed, etc.) - Will fix these in separate PRs - Update `contributing.md` to state that we've tested changes against Python 3.8-3.11 - Specifically 3.8.19, 3.9.19, 3.10.14, and 3.11.9 on MacOS Sonoma 14.4.1 - Update `CHANGELOG.md`
Update docs dependencies and Python version
build+docs: use Python 3.11 and pin a recent version of pytest
Specify image version for build
Add line_shape options to doc string
Fix small docstring typos
Handle `extras` option in `IntegerValidator`
Fixes a few doc string issues
Specify which maps require token
Update plotly.js to v2.34.0 + add docs
Add latest docs updates to master
Version changes for v5.23.0
Update docs Plotly.py version
archmoj
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge all the changes from main back to doc-prod to make the docs live