Skip to content

Make docs live for 5.23 #4689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 68 commits into from
Jul 23, 2024
Merged

Make docs live for 5.23 #4689

merged 68 commits into from
Jul 23, 2024

Conversation

LiamConnors
Copy link
Member

@LiamConnors LiamConnors commented Jul 23, 2024

Merge all the changes from main back to doc-prod to make the docs live

LiamConnors and others added 30 commits April 25, 2024 15:14
-   `conda create -n plotly-dev python` currently gives Python 3.12.3.
-   `pytest -v packages/python/plotly/plotly/tests/` then fails with `ModuleNotFoundError: No module named 'imp'`.
    -   `pip install imp` fails: the `imp` module was deprecated in Python 3.11 and has been removed in Python 3.12.
-   So update `contributing.md` to specify `conda create -n plotly-dev python=3.11`
-   But now `pytest` fails
    -   `File "<frozen importlib._bootstrap>", line 1072, in _find_spec`
    -   `AttributeError: 'AssertionRewritingHook' object has no attribute 'find_spec'`
-   Problem was `pytest==3.5.1` in `packages/python/plotly/optional-requirements.txt`
-   Update to `pytest==8.1.1` and `pytest` runs
    -   Some tests are failing (orca problems, `statsmodels` not installed, etc.)
    -   Will fix these in separate PRs
-   Update `contributing.md` to state that we've tested changes against Python 3.8-3.11
    -   Specifically 3.8.19, 3.9.19, 3.10.14, and 3.11.9 on MacOS Sonoma 14.4.1
-   Update `CHANGELOG.md`
Update docs dependencies and Python version
build+docs: use Python 3.11 and pin a recent version of pytest
Specify image version for build
LiamConnors and others added 26 commits July 3, 2024 09:47
Add line_shape options to doc string
Handle `extras` option in `IntegerValidator`
Fixes a few doc string issues
Specify which maps require token
Update plotly.js to v2.34.0 + add docs
@LiamConnors LiamConnors requested a review from archmoj July 23, 2024 14:26
Copy link
Contributor

@archmoj archmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@LiamConnors LiamConnors merged commit 975bbf7 into doc-prod Jul 23, 2024
5 checks passed
@LiamConnors LiamConnors deleted the make-docs-live-5-23 branch July 23, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants