Skip to content

Handle extras option in IntegerValidator #4612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented May 17, 2024

extras are added to plotly.js integer validator in plotly/plotly.js@37dee48
i.e. to handle cases like bold and normal in font.weight which could also be a number between 1-1000.

This commit would be required in updating to upcoming plotly.js v2.33.0.

@LiamConnors
cc: @emilykl @gvwilson

@LiamConnors LiamConnors self-requested a review June 13, 2024 15:30
@archmoj
Copy link
Contributor Author

archmoj commented Jun 13, 2024

@LiamConnors please merge this PR once you added a changelog regarding the changes, etc. as required.
Thank you very much in advance 🙏

@archmoj archmoj requested a review from LiamConnors June 13, 2024 16:20
@emilykl
Copy link
Contributor

emilykl commented Jun 13, 2024

Logic looks good to me. Thanks @archmoj !

Do we have tests for the validators? Can we add a test for this change?

@archmoj
Copy link
Contributor Author

archmoj commented Jun 13, 2024

Logic looks good to me. Thanks @archmoj !

Do we have tests for the validators? Can we add a test for this change?

Good call.
It would be nice to add tests for this PR.
@LiamConnors you may add a test in packages/python/plotly/_plotly_utils/tests/validators/test_dash_validator.py

Thank you!

@archmoj
Copy link
Contributor Author

archmoj commented Jul 3, 2024

@LiamConnors The tests used to pass before your commit which simply added a line to the changelog. But now it fails.
Do you have any idea why this is happening?

@LiamConnors
Copy link
Member

@archmoj if you update from master to bring in this change #4625
it should fix it

@archmoj
Copy link
Contributor Author

archmoj commented Jul 3, 2024

I'll add tests in a separate PR later.

@gvwilson gvwilson merged commit 16dd6a3 into master Jul 3, 2024
5 checks passed
@archmoj archmoj deleted the handle-extras-integer-validator branch July 3, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants