offline plot command - fixes https://github.com/plotly/plotly.py/pull/378
#378
Conversation
|
Here's a first pass at
hey @cldougl @theengineear - could you check this out? |
| if (plotly_platform_url != 'https://plot.ly' and | ||
| link_text == 'Export to plot.ly'): | ||
| plot([ | ||
| go.Scatter(x=[1, 2, 3], y=[3, 2 6]) |
|
@chriddyp first pass looks good- all the defaults are working well for me! |
| def plot(figure_or_data, | ||
| show_link=True, link_text='Export to plot.ly', | ||
| validate=True, output_type='file', | ||
| include_plotlyjs=True, |
There was a problem hiding this comment.
In the future, when plotly.js is modularized, we might allow folks to include sub-bundles here. Maybe something like plotlyjs_modules=['scatter', 'bar', 'maps'] which would overwrite the include_plotlyjs argument?
cc @etpinard
There was a problem hiding this comment.
🍻
maybe also a include_mathjax flag?
|
First pass looks good to me too!! |
|
hey @cldougl @theengineear - I just added tests. Could you take another look? Would like to merge this early next week :) |
|
Sweet! Thanks for adding tests! 💃 after you update the plot schema and tests 🎏 |
|
same here- 💃 after update/tests pass |
chriddyp
changed the title
plot commandplot command - fixes https://github.com/plotly/plotly.py/pull/378
|
Thanks heaps for this @chriddyp and all the testers! |
|
Excellent! Thanks @chriddyp! |
Description: Write Plotly graphs to an HTML file from Python.
Fixes - fixes #378