Skip to content

Add offline plotting that doesn't depend on Jupyter #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add offline plotting that doesn't depend on Jupyter #358

wants to merge 2 commits into from

Conversation

nzjrs
Copy link

@nzjrs nzjrs commented Nov 24, 2015

For discussion. Fixes #353

@chriddyp
Copy link
Member

nice, thanks @nzjrs !

I'd like plotly.offline.plot to also handle a few more things:

  • filename="temp-plotly.html" argument that saves the graph to the directory
  • auto_open=True argument which will open the plot in your web browser by default. We should piggyback on the config settings that a user can save in their config file: https://github.com/plotly/plotly.py/blob/master/plotly/plotly/plotly.py#L240
  • For standalone sizing, I think we should make the plot full window, make the div 100% x 100% of the body.
  • I love the idea of html_style idea! I'm not sure about what the use case is for body, it seems like div serves that purpose

chriddyp
chriddyp reviewed Nov 24, 2015
View reviewed changes
plotly/offline/offline.py

html = ""
if html_style == 'standalone':
html += '<html><head><script type="text/javascript">' + get_plotlyjs() + '</script></head><body>'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should include
<!DOCTYPE html> and <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">

@jackgolding
Copy link

If we wanted to create an internal dashboard (i.e. not plots hosted on plot.ly) using plot.ly would using iframes to these generated HTML files be a good idea or is this what we need the enterprise mode for?

@jackgolding jackgolding mentioned this pull request Dec 3, 2015
Closed
@baobobs
Copy link

baobobs commented Dec 11, 2015

Any progress on this? I'm excited to test this out once it's been successfully merged.

@chriddyp
Copy link
Member

Closing this in favor of #378

@chriddyp chriddyp closed this Dec 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nzjrs @chriddyp @jackgolding @baobobs