added minimal test for px #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was thinking of testing all the examples of the tutorial written by @nicolaskruchten so that we know that at least those function calls will execute. |
|
I'm doing this since I'm about to start playing with the API of px so I'd prefer to know quickly what I'm breaking :-) |
|
Pandas is an optional dependency for plotly.py, but is it ok to have it as a required dependency for testing? |
|
I'm fine with this approach as a basic smoke test, but I wouldn't go super-far with individual attribute spot-checks, given how many there are! |
|
💃 once rebased onto |
emmanuelle
force-pushed
the
px-tests
branch
from
6a0f3f3 to
936e9ea
Compare
|
ok, clean build, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of course many more tests for px, but I'm opening this PR as a placeholder to comment about how px tests should look like.