Skip to content

Commit 7ec7a69

Browse files
authored
added minimal test for px (#1754)
Pandas was added to test dependencies, and numpy and scikit-image versions were changed
1 parent 074408f commit 7ec7a69

File tree

4 files changed

+20
-7
lines changed

4 files changed

+20
-7
lines changed

Diff for: packages/python/plotly/plotly/figure_factory/_ternary_contour.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
from plotly.graph_objs import graph_objs as go
77

88
np = optional_imports.get_module("numpy")
9-
sk_measure = optional_imports.get_module("skimage.measure")
109
scipy_interp = optional_imports.get_module("scipy.interpolate")
1110

11+
from skimage import measure
1212

1313
# -------------------------- Layout ------------------------------
1414

@@ -305,8 +305,8 @@ def _extract_contours(im, values, colors):
305305
all_contours1, all_values1, all_areas1, all_colors1 = [], [], [], []
306306
all_contours2, all_values2, all_areas2, all_colors2 = [], [], [], []
307307
for i, val in enumerate(values):
308-
contour_level1 = sk_measure.find_contours(zz_min, val)
309-
contour_level2 = sk_measure.find_contours(zz_max, val)
308+
contour_level1 = measure.find_contours(zz_min, val)
309+
contour_level2 = measure.find_contours(zz_max, val)
310310
all_contours1.extend(contour_level1)
311311
all_contours2.extend(contour_level2)
312312
all_values1.extend([val] * len(contour_level1))
@@ -614,6 +614,7 @@ def create_ternary_contour(
614614
"""\
615615
The create_ternary_contour figure factory requires the scipy package"""
616616
)
617+
sk_measure = optional_imports.get_module("skimage")
617618
if sk_measure is None:
618619
raise ImportError(
619620
"""\
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import plotly.express as px
2+
import numpy as np
3+
4+
5+
def test_scatter():
6+
iris = px.data.iris()
7+
fig = px.scatter(iris, x="sepal_width", y="sepal_length")
8+
assert fig.data[0].type == "scatter"
9+
assert np.all(fig.data[0].x == iris.sepal_width)
10+
assert np.all(fig.data[0].y == iris.sepal_length)
11+
# test defaults
12+
assert fig.data[0].mode == "markers"

Diff for: packages/python/plotly/plotly/tests/test_optional/test_figure_factory/test_figure_factory.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
shapely = optional_imports.get_module("shapely")
1616
shapefile = optional_imports.get_module("shapefile")
1717
gp = optional_imports.get_module("geopandas")
18-
sk_measure = optional_imports.get_module("skimage.measure")
18+
sk_measure = optional_imports.get_module("skimage")
1919

2020

2121
class TestDistplot(NumpyTestUtilsMixin, TestCaseNoTemplate):

Diff for: packages/python/plotly/tox.ini

+3-3
Original file line numberDiff line numberDiff line change
@@ -59,22 +59,22 @@ deps=
5959
pytz==2016.10
6060
retrying==1.3.3
6161
pytest==3.5.1
62+
pandas==0.24.2
6263
backports.tempfile==1.0
6364
optional: --editable=file:///{toxinidir}/../plotly-geo
64-
optional: numpy==1.11.3
65+
optional: numpy==1.16.5
6566
optional: ipython[all]==5.1.0
6667
optional: ipywidgets==7.2.0
6768
optional: ipykernel==4.8.2
6869
optional: jupyter==1.0.0
69-
optional: pandas==0.19.2
7070
optional: scipy==0.18.1
7171
optional: shapely==1.6.4
7272
optional: geopandas==0.3.0
7373
optional: pyshp==1.2.10
7474
optional: pillow==5.2.0
7575
optional: matplotlib==2.2.3
7676
optional: xarray==0.10.9
77-
optional: scikit-image==0.13.1
77+
optional: scikit-image==0.14.4
7878

7979
; CORE ENVIRONMENTS
8080
[testenv:py27-core]

0 commit comments

Comments
 (0)