Skip to content

V4 refine dependencies #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 19, 2019
Merged

V4 refine dependencies #1631

merged 8 commits into from
Jun 19, 2019

Conversation

jonmmease
Copy link
Contributor

@jonmmease jonmmease commented Jun 19, 2019

This PR cleans up the distribution package dependencies for the plotly package now that chart_studio has been split off.

I was able to remove 3 hard dependencies:

  1. I replaced the nbformat hard-dependency with runtime validation (this fully resolves unneeded dependency on nbconvert #771). nbformat is only needed for mimetype rendering, so that's where the validation happens. It's not needed to generate HTML output.
  2. The pytz library is no longer needed now that we stopped performing time-zone translation (Stop auto-converting timezones to UTC and stripping timezone info #1581)
  3. The requests library is only used for orca image export. There was already validation to make sure the optional psutil library is installed for use with orca, so I added requests validation there too.
  4. the decorator package was only being used for an unused memoize function. So both the function and dependency have been removed.

Required dependencies for the plotly package are now: install_requires=["retrying>=1.3.3", "six"],

@jonmmease jonmmease changed the base branch from master to v4_integration June 19, 2019 17:23
@jonmmease jonmmease merged commit b90126e into v4_integration Jun 19, 2019
@nicolaskruchten nicolaskruchten deleted the v4_update_dependencies branch June 19, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant