-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
unneeded dependency on nbconvert #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Ok, so here's the back story on the I feel comfortable removing this dependency now because our jupyter installation instructions specify cc @chriddyp |
I'm OK with keeping it in. Not everyone follows the instructions and we really do need that minimum version. |
Ok, yeah. it's probably not worth risking a regression by changing this. This is a tricky problem in general for us now though. We also need ipywidgets >7 for On the conda side there is a |
I would like to open this up again, I have a scenario where we are not using Jupyter notebooks, but want to use plotly. Note: I am installing plotly from pip. |
Hi @AbdealiJK, Thanks for describing how this dependency has caused you issues. I think version 4 will be a good time to change this. In version 4 we are making a concerted effort to make it more pleasant to use plotly.py in non-jupyter contexts, so this would fit well with that goal.
|
I'm OK with it if @chriddyp doesn't object. |
Doing this for v4 in #1631. I removed the hard dependency and opted for a runtime check on the version of |
On a slightly unrelated note, I was trying to understand the changes that were planned on plotly v4 - specifically I was interested in whether plotly transforms were being supported better (currently I have to convert to JSON > dict and then add transforms) And couldn't find a place to identify all v4 changes. I did see plotly_future .v4 |
Hi @AbdealiJK, The best summary right now is probably the V4 GitHub tag. We'll be working on better release notes soon. Thanks |
AFAICT nbconvert only appears to be used in the tests, yet is required to be installed. nbconvert then itself depends on jupyter-core.
maybe they can be moved to a test dependency and not a run-time one?
The text was updated successfully, but these errors were encountered: