-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Position title after legend width calculated #6725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I've bundled a couple of other issue fixes in here
|
I'm stumped, the tests pass on my personal dockers, and regenerating the images isn't helping |
There is a bug in our image test system depending on the rendering order. |
Please write |
💃 |
To continue fixing #6668 (comment)
The original method worked because the legend-draw function is called multiple times. I don't know why, it seems like a mistake. On the 2nd call, the legend has been drawn and
legendObj._width
has been calculated.Sometimes the function is only called once. I was able to reproduce by changing the height of one of the mocks. This mean legend horizontal align didn't work.
I've updated the code to re-draw the legend title after
computeLegendDimensions
computeLegendDimensions