-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Use of named colours in scatterGL is not case-insenstive #6685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The issue is inside this package: which utilizes this package: where we can see all the string -> color code translation is in lower case Created this issue -> colorjs/color-parse#5 |
@archmoj looks like you're a maintainer of that repo. If you agree with this analysis, let's create a new version |
note that the package dependency path is ScatterGl -> plot.js -> regl-line2d -> color-normalize -> color-rgba -> color-parse |
@28raining Yes please feel free to submit a PR. Thank you! |
Added to PR #6725 |
When using CSS colour names for a marker color, they should be case insensitive. I expected
LemonChiffon
to works as it is valid CSS3 colour, and works in svg, however a scatterGL trace renders it as black.A simple fix would be to apply a lowercase before setting colours in the scattergl code, though I am not entirely sure why this isn't working currently.
Codepen:
https://codepen.io/dsmmcken/pen/JjeambK
The text was updated successfully, but these errors were encountered: