Fix gl3d ticks when converting dates to milliseconds #4903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
added
bug
1 task
alexcjohnson
reviewed
Jun 5, 2020
| @@ -90,7 +90,7 @@ module.exports = function setConvert(ax, fullLayout) { | |||
| * - inserts a dummy arg so calendar is the 3rd arg (see notes below). | |||
| * - defaults to ax.calendar | |||
| */ | |||
| function dt2ms(v, _, calendar, msUTC) { | |||
| function dt2ms(v, _, calendar, opts) { | |||
There was a problem hiding this comment.
good call. At some point I bet we could collapse all these extra args into a single opts arg (ie dt2ms(v, opts)) but that's a big and potentially risky project - which some users may consider a breaking change though the ax.a2b functions are sufficiently "internal" that I personally wouldn't be bothered by it. Anyway not a change to make now.
alexcjohnson
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #3721 and fixes #4902.
Demo: Before vs After.
@plotly/plotly_js