Adjust local time offset help improve display short time periods (hours) in gl3d plots #3721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As partly described in #3306 when dealing with short times on gl3d axes, there are two problems involved:
One is that we need to deal with float numbers right close to precision limits (noting that floats are generally good when the data is uniformly distributed around zero). This could be improved when #2646 is addressed.
The second problem is that the date ticks presented in the browser shifted depending on user time zone.
This PR is an attempt to solve the second issue.
@alexcjohnson
@plotly/plotly_js