-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix react category order of matching axes #4832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 Looks good, and for the short term this is probably the safest solution. But my comment about "maybe we can avoid relinking these axes entirely" was sincere - see #749, it's very likely that we're majorly overdoing this, and we'll continue creating new bugs with this step until we identify the specific reason why some keys need relinking, others need to NOT be relinked, and still others don't care. The end result, I suspect, will be an opt-in relink step rather than the current opt-out.
What is hapening (I think) is that this block plotly.js/src/plots/cartesian/set_convert.js Lines 877 to 909 in 4d383f2
I added few more tests in c2dc252. & merging... |
Fixes #4718 and fixes #4826 | before vs after.
@plotly/plotly_js