Skip to content

Data order is not applied by React when using matching axes #4718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
archmoj opened this issue Apr 1, 2020 · 3 comments · Fixed by #4832
Closed

Data order is not applied by React when using matching axes #4718

archmoj opened this issue Apr 1, 2020 · 3 comments · Fixed by #4832
Assignees
@archmoj
Labels
bug something broken
Milestone
v1.54.2

Comments

@archmoj
Copy link
Contributor

archmoj commented Apr 1, 2020

Originally reported in plotly/dash#1163.
MINIMAL DEMO
@archmoj archmoj added the bug something broken label Apr 1, 2020
@archmoj archmoj mentioned this issue Apr 1, 2020
Closed
@archmoj
Copy link
Contributor Author

archmoj commented Apr 2, 2020

Not clear how we could bypass _categories here?

plotly.js/src/lib/relink_private.js

Line 30 in d37895b

if(k.charAt(0) === '_' || typeof fromVal === 'function') {

@archmoj
Copy link
Contributor Author

archmoj commented Apr 2, 2020

It may be best to use re-direct to newPlot from react when there are category axes matches one another.

@alexcjohnson
Copy link
Collaborator

We can't do newPlot - both for performance reasons and for uirevision

Normally it looks like we clear _categories in ax.clearCalc, and there's even logic in there that looks like it's supposed to apply to linked axes... why isn't that working?

@alexcjohnson alexcjohnson mentioned this issue May 11, 2020
Closed
@nicolaskruchten nicolaskruchten added this to the v1.54.2 milestone May 12, 2020
@archmoj archmoj self-assigned this May 13, 2020
@archmoj archmoj mentioned this issue May 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@archmoj archmoj

Labels
bug something broken
Projects
None yet
Milestone
v1.54.2
Development

Successfully merging a pull request may close this issue.

Fix react category order of matching axes plotly/plotly.js
3 participants
@nicolaskruchten @alexcjohnson @archmoj