Trigger plotly_relayout event when camera is reset to default or saved (Solves #FI29)

[monfera]

Fixes issue #FI29. The added test cases aren't part of CircleCI as the test file is excluded, but they pass when run locally with fdescribe.

[monfera]

@etpinard @bpostlethwaite I believe these changes address FI-29.

[etpinard]

We could do even better passing the corresponding camera attribute update object e.g:

this.graphDiv.emit('plotly_relayout', {
  scene: {
    eye: { x: 1.25, y: 1.25, z: 1.25 },
    center: { x: 0, y: 0, z: 0 },
    up: { x: 0, y: 0, z: 1 }
  }
});

[monfera]

@etpinard I'm glad to refactor for it; I'll extract the object-to-array logic into a separate function so we can be DRY among these two emit places.

[etpinard]

👍

[etpinard]

Oh. To handle the mulit-scene case ⏫ should in fact be:

var update = {};

update[this.id] = {
    eye: { x: 1.25, y: 1.25, z: 1.25 },
    center: { x: 0, y: 0, z: 0 },
    up: { x: 0, y: 0, z: 1 }
  };

this.graphDiv.emit('plotly_relayout', update);

where this.id can be scene, scene2, scene3, etc.

[etpinard]

Ok. I'm ok with this.

We should spend some time rethinking how scene.camera interacts with Plotly.relayout so that e.g. the mode bar buttons could simply call Plotly.relayout with the correct update object without having to use an internal Scene method.

That will be for another day (possibly before v2.0.0) though.

[etpinard]

This assertion is misleading. Adding

console.log(getOrbitCamera(cameraData))

above this line in Scene.prototype.setCamera logs

[[0.1, 0.1, 1], [0, 0, 0], [0, 0, 1]]

for the first scene, and

[[2.5, 2.5, 2.5], [0, 0, 0], [0, 0, 1]]

for the second scene.

I think the jasmine spy, holds on to the arguments of the first relayoutCallback call and isn't updated for subsequent calls.

Moreover, we should make it clear that plotly_relayout is triggered twice (one per each scene) when clicking on these buttons.

[monfera]

Thanks @etpinard, I'll try to capture the multi-scene aspect.

[etpinard]

nice move.

[etpinard]

@monfera Great way to get introduced with our gl3d code. Nicely done 🍻