Skip to content

Running tests on windows #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Hypercubed opened this issue Nov 24, 2015 · 3 comments
Closed

Running tests on windows #29

Hypercubed opened this issue Nov 24, 2015 · 3 comments

Comments

@Hypercubed
Copy link
Contributor

Anyone else having issues running the karma tests? First issue I had was the tasks\util\shortcut_paths.js transform (invalid directory delimiter for windows). That was easy to fix. But even after this npm test produces the error ReferenceError: Can't find variable: require. Looks like karma-browserify is not working as expected.
@Hypercubed
Copy link
Contributor Author

I am confident that this is an issue with karma-browserify on windows. I'll reopen if I find otherwise.

@Hypercubed
Copy link
Contributor Author

There were two issues preventing npm run test-jasmine on windows:

  1. karma-browserify had a bug (Fixed in fix(preprocessor): use full path to temp dir for browserify-bundle pr… nikku/karma-browserify#154).
  2. On windows (or cygwin) paths generated by the requireTransform browserify transform contain platform-specific file separators (patch is coming).

@Hypercubed Hypercubed reopened this Nov 30, 2015
@Hypercubed Hypercubed mentioned this issue Nov 30, 2015
Merged
@etpinard
Copy link
Contributor

fixed in #46

monfera added a commit to monfera/plotly.js that referenced this issue Apr 21, 2016
@monfera
plotly#29 add plotly_relayout event emission when camera is reset to …
0b04e60 
…default or saved
monfera added a commit to monfera/plotly.js that referenced this issue Apr 21, 2016
@monfera
plotly#29 add plotly_relayout event emission when camera is reset to …
d6037c0 
…default or saved
monfera added a commit to monfera/plotly.js that referenced this issue Apr 21, 2016
@monfera
plotly#29 add test cases (they're in the CI excluded file but they pa…
8dedb6e 
…ss fine locally with fdescribe)
monfera added a commit to monfera/plotly.js that referenced this issue Apr 21, 2016
@monfera
plotly#29 different camera format, and ensuing code unification
ff1d418
monfera added a commit to monfera/plotly.js that referenced this issue Apr 21, 2016
@monfera
plotly#29 ensure one call per scene, checking against correct callbac…
57b2650 
…k argument values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Hypercubed @etpinard