-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add initial zh-CN translation based on ja.js dictionary strings #4276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks very much for the PR, can you now please @ mention a few other speakers of this language who can help review your translations? |
Ping @boltomli - do you know any other Github users that are native speakers of |
Maybe @byronz could take a look? |
@Sunshow might have time to check as well? |
Co-Authored-By: Byron Zhu <[email protected]>
Co-Authored-By: Byron Zhu <[email protected]>
Co-Authored-By: Byron Zhu <[email protected]>
Co-Authored-By: Byron Zhu <[email protected]>
Ok - |
Thanks for your interest in plotly.js!
Translations:
lib/locales/
, not those indist/
Features, Bug fixes, and others:
Developers are strongly encouraged to first make a PR to their own plotly.js fork and ask one of the maintainers to review the modifications there. Once the pull request is deemed satisfactory, the developer will be asked to make a pull request to the main plotly.js repo and may be asked to squash some commits before doing so.
Before opening a pull request, developer should:
git rebase
their local branch off the latestmaster
,git add
thedist/
folder (thedist/
is updated only on version bumps),package-lock.json
file (if any),Note that it is forbidden to force push (i.e.
git push -f
) to remote branches associated with opened pull requests. Force pushes make it hard for maintainers to keep track of updates. Therefore, if required, pleasegit merge master
into your PR branch instead ofgit rebase master
.