Skip to content

Schema animatable + anim fixes #4024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2019
Merged

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Jul 5, 2019

resolves #3737

In brief, anim: true specifications in attribute declarations are now dropped in modules that don't set animatable: true during Plotly.PlotSchema.get()

would be nice to slip this one in 1.49.0 - @plotly/plotly_js

@etpinard etpinard added bug something broken status: reviewable labels Jul 5, 2019
@archmoj
Copy link
Contributor

archmoj commented Jul 5, 2019

Excellent.
💃

@etpinard etpinard merged commit 46f4cfc into master Jul 8, 2019
@etpinard etpinard deleted the schema-animatable-anim-fixes branch July 8, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bar attributes shouldn't have anim:true in the schema
2 participants