Skip to content

Bar attributes shouldn't have anim:true in the schema #3737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cpsievert opened this issue Apr 5, 2019 · 3 comments · Fixed by #4024
Closed

Bar attributes shouldn't have anim:true in the schema #3737

cpsievert opened this issue Apr 5, 2019 · 3 comments · Fixed by #4024
Assignees
@etpinard

Comments

@cpsievert
Copy link

Perhaps this is expected, but I found it surprising since bar's y atttribute has a anim: true flag in this config (this means it should work with the react transitioning API, right?)

https://codepen.io/cpsievert/pen/axZZeP
@etpinard

This comment has been minimized.

Sign in to view
@etpinard etpinard marked this as a duplicate of #1019 Apr 5, 2019
@etpinard etpinard closed this as completed Apr 5, 2019
@etpinard etpinard reopened this Apr 5, 2019
@etpinard
Copy link
Contributor

etpinard commented Apr 5, 2019 •
edited
Loading

Ha oops. Sorry @cpsievert I misread the issue. I thought we were asking whether bar traces can be smoothly transitioned. The answer is no.

But you're right, anim: true for x, y etc should not be there in the bar trace schema. Have you noticed anim: true showing up anywhere else?

@etpinard etpinard changed the title Plotly.react() transitions don't appear to work for bar heights? Bar attributes shouldn't have anim:true in the schema Apr 5, 2019
@cpsievert
Copy link
Author

No, but I haven't really been playing around with Plotly.react() much at all yet

@etpinard etpinard self-assigned this May 24, 2019
@etpinard etpinard marked this as not a duplicate of #1019 Jun 5, 2019
@etpinard etpinard mentioned this issue Jul 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etpinard etpinard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Schema animatable + anim fixes plotly/plotly.js
2 participants
@cpsievert @etpinard