Skip to content

More stable jasmine2 test runs #3756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2019
Merged

More stable jasmine2 test runs #3756

merged 1 commit into from
Apr 10, 2019

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Apr 10, 2019

#3667 solved the failing issues of jasmine3 container.
However, rerunning jasmine2 still is take some time & attention.
This PR can help improve this situation by simply reducing the shards limits from default 20 to 5.
@plotly/plotly_js

Before:
Jasmine2_limit20

After:
Jasmine2_Limit5

@etpinard
Copy link
Contributor

Cool. Let's give this a shot 💃

@archmoj archmoj merged commit b6a5298 into master Apr 10, 2019
@archmoj archmoj deleted the fix-jasmine2-fails branch April 10, 2019 19:23
@etpinard
Copy link
Contributor

Next stop: maybe bumping jasmine-core and karma-jasmine could help cc #3368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants