Adapt jasmine tests for jasmine-core@3

[etpinard]

npm i [email protected] [email protected]
npm run test-jasmine -- --nowatch

make numerous tests fail, spits out deprecation warnings:

and doesn't get along with our negateIf custom matcher

plotly.js/test/jasmine/assets/custom_matchers.js

Lines 212 to 215 in cbaae9a

	jasmine.Expectation.prototype.negateIf = function(negate) {
	if(negate) return this.not;
	return this;
	};

---

More info about jasmine@3:

https://github.com/jasmine/jasmine/blob/master/release_notes/3.0.md

More info about karma-jasmine@2:

https://github.com/karma-runner/karma-jasmine/blob/master/CHANGELOG.md#200-2018-11-15

[etpinard]

... and note that [email protected] is only compatible with karma-jasmine@2x

https://github.com/mnasyrov/karma-jasmine-spec-tags

[etpinard]

See https://github.com/plotly/plotly.js/tree/bump-jasmine for the current state of affairs.

[etpinard]

It seems that the new jasmine-core version shuffle the tests by default. We'll need to rewrite the tests have a @noCIdep tag.

EDIT: yep, it stated:

here under the breaking changes.

• Random tests jasmine/jasmine#927

[etpinard]

their docs look more thorough than before too:

https://jasmine.github.io/api/3.4/global

[etpinard]

Things are looking up!

By setting random: false thus making our test running in order (like they are currently) make npm run test-jasmine run smooth ⛵

https://github.com/plotly/plotly.js/compare/bump-jasmine

Now, the main "blocker" is negateIf. We either:

• convert its declaration to something that jasmine-core@v3 is ok with (see src for inspiration), or
• 🔪 it and adapt the tests currently using negateIf .

As adding stuff to the jasmine.Expectation prototype isn't recommended in jasmine docs, I'll vote for the 🔪 . Does anyone oppose?

[etpinard]

[email protected] added expect(...).withContext('extra message').toEqual(...) to (finally) make toEqual(...) log extra info in failure messages.

https://github.com/jasmine/jasmine/blob/master/release_notes/3.3.0.md

🎉

[alexcjohnson]

🔪 negateIf is fine - it's just a convenience. If it becomes cumbersome without it, could always turn it into a plain function... just doesn't read quite as well as the method.

function negateIf(expectation, condition) {
   return condition ? expectation.not : expectation
}