-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Orthographic projection for 3D plots - finalist #3550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
adjust ortho camera dist in module and added orthographic mocks adjust camera structure in jasmine test & corrected baselines
package.json
Outdated
@@ -81,7 +81,7 @@ | |||
"gl-mat4": "^1.2.0", | |||
"gl-mesh3d": "^2.0.7", | |||
"gl-plot2d": "^1.4.2", | |||
"gl-plot3d": "^1.6.3", | |||
"gl-plot3d": "git://github.com/gl-vis/gl-plot3d.git#33d5169a62d9b903a8f3a4607f4dae726c4bb57b", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also regarding gl-axes3d
changes... https://github.com/gl-vis/gl-axes3d/compare/ortho-view1
@archmoj this is starting to look good! Nice work! About
First you'll need to change the plotly.js/src/plots/gl3d/scene.js Lines 800 to 842 in 25fa0c2
to update the projection? |
Awesome work @archmoj !! Adding this to 💃 💃 💃 |
Supersedes #3331.
Fixes #2611 by adding orthographic views to Plotly graphs.
A new attribute
ortho
is defined on the camera object (defaulted tofalse
) and passed togl-plot3d
andgl-axes3d
modules.The scene initialisation now uses the camera initial vectors as well as
ortho
attribute.The createCamera function needed in
plot/gl3d/scene.js
andgl-vis/gl-plot3d
is centralised in a separate module (i.e. a fork of3d-view-controls
while applying Plotly.js camera.js latest changes).Interactive demo.
TODO:
relayout
path to start new scene when switching betweenorthographic
andperspective
projections.@plotly/plotly_js
@jackparmer