Make scrollZoom config option a flaglist #3422
Conversation
- which match the current "default", but will make scrollZoom:false disable zoom for all subplots!
|
... to be merge into #3376 where I made use of the new |
|
Nice solution, I like it! |
|
@archmoj would you mind taking a look at this one at some point this week? |
|
@etpinard OK. That's interesting. I'll have a look. |
|
Thanks for the revision! |
|
No problem! Thank you for the review! |
| scene.glplot.canvas.addEventListener('wheel', function() { | ||
| if(gd._context._scrollZoom.gl3d) { | ||
| relayoutCallback(scene); | ||
| } | ||
| }, passiveSupported ? {passive: false} : false); |
There was a problem hiding this comment.
I've disabled scrollZoom in the plot config, but the mouse is still getting captured when scrolling by the canvas. Looks like it's because of the wheel event listener that's being registered here anyway. After I remove the wheel listener on scene element from chrome inspector, scrolling the page no longer gets captured by the canvas.
@etpinard, can we not add the listener at all if scrollzoom is disabled?
There was a problem hiding this comment.
@zfei thanks for the debugging. This comment is going to get lost here on a merged PR though, can you make a new issue for this? Or better yet a PR, looks like it's probably a pretty easy fix 😎
There was a problem hiding this comment.
Thanks @alexcjohnson.
I've never touched the Plotly codebase and haven't set up my mind to go through the learning curve yet. 😉
Will just leave it as an issue for now.
An attempt at resolving #143 and #2998 as well as a similar issue-less problem for mapbox subplots.
In brief, this PR makes the config option
scrollZooma flaglist -- with flags for all subplots that support zooming via scroll -- instead of a boolean:gl3d+geo+mapbox(instead offalse) as all three of these subplot types have scroll zoom enabled by default.scrollZoom:trueenables scroll zoom for all subplots, which is equivalent toscrollZoom:'cartesian+gl3d+geo+mapbox'scrollZoom:falsedisables scroll zoom on all subplots, which should make a bunch of users 😄@plotly/plotly_js what do you think?