This repository was archived by the owner on Jun 3, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 143
Graph config defaults don't match plotly.js #514
Labels
dash-type-bug
Something isn't working as intended
Comments
Cc @wbrgss |
Did a little investigation of the current
For the moment I'll make a PR to remove the defaults and add documentation for the new entries. Later - unless it's quick and I can get it in for the upcoming release - I'll make another PR to test that these keys continue to match when we upgrade plotly.js. |
Actually I'm not going to include |
Closing - #515 fixes the bug by removing the nested defaults, and includes a test that |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Graph
sets its ownconfig
defaults here - but this has no mechanism to keep up to date with plotly.js, and in fact it's out of date already in at least one respect,scrollZoom
, as of plotly/plotly.js#3422We should either remove those defaults entirely, or programmatically match them to plotly.js.
There's a related problem: if you override a piece of the config, the rest of the default gets dropped. So for example right now if you were to set something unrelated like
showLink: true
, thescrollZoom: false
would be dropped - and set to the new plotly.js default!cc @nicolaskruchten @michaelbabyn - discovered while researching plotly/plotly.js#3738
The text was updated successfully, but these errors were encountered: