Fix horizontal box/violin hover label misalignment under hovermode:'closest' #3401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- that 'posref' val is used to sort the labels before the during the 'avoid-overlap' algo.
... and still tests what we want to test
|
Note that this PR doesn't make #2970 "worse" - unlike #3396 (comment) |
test/jasmine/tests/violin_test.js
Outdated
| @@ -489,6 +489,40 @@ describe('Test violin hover:', function() { | |||
| nums: '(96, Old Faithful)', | |||
| name: '', | |||
| isRotated: false | |||
| }, { | |||
| desc: 'orientation:h | hovermode;y', | |||
There was a problem hiding this comment.
Colon or semicolon here?
test/jasmine/tests/box_test.js
Outdated
| @@ -312,6 +312,29 @@ describe('Test box hover:', function() { | |||
| }, | |||
| nums: 'look:0.7', | |||
| name: '' | |||
| }, { | |||
| desc: 'orientation:h | hovermode;y', | |||
There was a problem hiding this comment.
Colon or semicolon?
|
💃 if the colon/semicolon is a display-only thing, which it appears to be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3050 (although it might worth moving #3050 (comment) into a new issue).
The idea behind this patch came from @nicolaskruchten 's #3396 - which revealed that something was wrong with how box/violin horizontal hover labels were sorted before the avoid-overlap algo. This PR is essentially a continuation of #3043
I have to add some tolerance in the kde hover label text assertion, but other than that this PR is ready to review cc @plotly/plotly_js