Skip to content

better default order for multiple hovers #3396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nicolaskruchten
Copy link
Contributor

@nicolaskruchten nicolaskruchten commented Jan 4, 2019

Closes #3389 AND closes #3050 :)

@nicolaskruchten
Copy link
Contributor Author

Note that this makes #2970 a bit worse, because it'll show only 'min' and not 'median' any longer, because that's now the first hover.

@nicolaskruchten
Copy link
Contributor Author

LMK if you like the fix and I'll fix the tests

@etpinard etpinard added bug something broken status: in progress labels Jan 4, 2019
@etpinard
Copy link
Contributor

etpinard commented Jan 4, 2019

Thanks for the PR!

Going from:

peek 2019-01-04 15-30

to:

peek 2019-01-04 15-31

is amazing 🎉

I'm a little confused about why your patch works though.

Fx.hover doesn't seem to care about the ordering of the labels of vertical box/violin traces and of horizontal box/violin traces under hovermode:'y'. I'll try to dig a little deeper. Maybe Fx.hover is just missing a .sort() for horizontal labels.

@nicolaskruchten
Copy link
Contributor Author

Hehehe like I said, I just looked at it and thought "seems like they're laying out in order and jamming each other up" ... I didn't dig into the root cause at all, but if there's a deeper/more elegant fix I'm all for it.

@etpinard
Copy link
Contributor

etpinard commented Jan 4, 2019

My attempt in -> #3401

@etpinard etpinard deleted the box_hover_fix branch January 21, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizontal box hover labels out of order Misalignment of horizontal box/violin hover labels
2 participants