-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Use Node 10 and npm 6 for development #2934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Huh... the first test failure is just a slightly different rounding result - should be able to just increase the tolerance. But the second, we still have the explicit timezone-setting step: I see two timezone switches in the chrome flags: Actually, looking at where that page got its info from, maybe this is the new one that would help us: |
... so that env variable can be accessed by jasmine tests
Whew, fixing the timezone issue was harder than it should have been, thanks for persevering there! This looks great. 💃 |
Interesting. I guess Chrome 68 is slower than Chrome 64? |
- this makes `npm ls --prod` exits with code 0.
... and Chrome 68 on CI.
Node 10 will become LTS in October, but why wait?
Switching to Node 10 makes us the latest major npm version with improved package-lock and faster installs and the latest v8 engine, speeding up our builds and CI runs (e.g. the
build
job on CI runs 30s faster,syntax
is 30s faster too).The switch to Chrome 68 appears to make two tests consistently fail:
The second one is probably related to #2747 (we might need to put a
@noCI
tag on that one).