Merge pull request #2934 from plotly/node10

Use Node 10 and npm 6 for development

Author: etpinard

.circleci/config.yml

@@ -10,7 +10,7 @@ version: 2.0
 jobs:
   build:
     docker:
-      - image: circleci/node:8.9.4
+      - image: circleci/node:10.9.0
     working_directory: ~/plotly.js
     steps:
       - checkout
@@ -47,33 +47,25 @@ jobs:
   test-jasmine:
     docker:
       # need '-browsers' version to test in real (xvfb-wrapped) browsers
-      - image: circleci/node:8.9.4-browsers
+      - image: circleci/node:10.9.0-browsers
     working_directory: ~/plotly.js
     steps:
       - checkout
       - attach_workspace:
           at: ~/plotly.js
-      - run:
-          name: Set timezone to Alaska time (arbitrary timezone to test date logic)
-          command: |
-            sudo cp /usr/share/zoneinfo/America/Anchorage /etc/localtime
       - run:
           name: Run jasmine tests (batch 1)
           command: ./.circleci/test.sh jasmine
 
   test-jasmine2:
     docker:
       # need '-browsers' version to test in real (xvfb-wrapped) browsers
-      - image: circleci/node:8.9.4-browsers
+      - image: circleci/node:10.9.0-browsers
     working_directory: ~/plotly.js
     steps:
       - checkout
       - attach_workspace:
           at: ~/plotly.js
-      - run:
-          name: Set timezone to Alaska time (arbitrary timezone to test date logic)
-          command: |
-            sudo cp /usr/share/zoneinfo/America/Anchorage /etc/localtime
       - run:
           name: Run jasmine tests (batch 2)
           command: ./.circleci/test.sh jasmine2
@@ -118,7 +110,7 @@ jobs:
 
   test-syntax:
     docker:
-      - image: circleci/node:8.9.4
+      - image: circleci/node:10.9.0
     working_directory: ~/plotly.js
     steps:
       - checkout

.circleci/test.sh

@@ -33,16 +33,27 @@ retry () {
     fi
 }
 
+# set timezone to Alaska time (arbitrary timezone to test date logic)
+set_tz () {
+    sudo cp /usr/share/zoneinfo/America/Anchorage /etc/localtime
+    export TZ='America/Anchorage'
+}
+
 case $1 in
 
     jasmine)
+        set_tz
+
         npm run test-jasmine -- --skip-tags=gl,noCI,flaky || EXIT_STATE=$?
         retry npm run test-jasmine -- --tags=flaky --skip-tags=noCI
         npm run test-bundle || EXIT_STATE=$?
+
         exit $EXIT_STATE
         ;;
 
     jasmine2)
+        set_tz
+
         SHARDS=($(node $ROOT/tasks/shard_jasmine_tests.js --tag=gl))
 
         for s in ${SHARDS[@]}; do

CONTRIBUTING.md

@@ -34,12 +34,12 @@ We use the following [labels](https://github.com/plotly/plotly.js/labels) to tra
 #### Prerequisites
 
 - git
-- [node.js](https://nodejs.org/en/). We recommend using node.js v8.x, but all
+- [node.js](https://nodejs.org/en/). We recommend using node.js v10.x, but all
   versions starting from v6 should work.  Upgrading and managing node versions
   can be easily done using [`nvm`](https://github.com/creationix/nvm) or its
   Windows alternatives.
-- [`npm`](https://www.npmjs.com/) v5.x and up (which ships by default with
-  node.js v8.x) to ensure that the
+- [`npm`](https://www.npmjs.com/) v6.x and up (which ships by default with
+  node.js v10.x) to ensure that the
   [`package-lock.json`](https://docs.npmjs.com/files/package-lock.json) file is
   used and updated correctly.