Fixedrange click #2279
Merged
Fixedrange click #2279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dfcreative 5th time's a charm 🙃 Lets get #2278 or some squashed version merged ASAP and 🙏 our tests get more reliable! |
dy
reviewed
Jan 23, 2018
| dragger.onmousedown = null; | ||
| dragger.style.pointerEvents = isMainDrag ? 'all' : 'none'; | ||
| dragger.style.pointerEvents = 'none'; |
There was a problem hiding this comment.
That is called just once per dragger element, right? Ie. it does not need to be reset to pointerEvents 'all'.
There was a problem hiding this comment.
Good thinking - I had to check, but yes, if you change it later so this needs pointerEvents, it will be reinstated by dragElement.init
|
@alexcjohnson looks good, although not sure I can review the whole logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2265
In #2241 we consolidated click behavior into the drag handler, for cartesian subplots. But this inadvertently disabled click when the drag handler was not attached - ie when there's nothing to drag because you're in zoom or pan mode and all the axes are
fixedrange!@dfcreative please take a look!