Skip to content

Intermittent errors fix #2278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Intermittent errors fix #2278

wants to merge 13 commits into from

Conversation

dy
Copy link
Contributor

@dy dy commented Jan 22, 2018

@alexcjohnson this may (partially) fix intermittent test failures.

The reason seems to be too many webgl contexts and/or losing gd or alike.
Splitting gl_plot_interact by gl2d_plot_interact and gl3d_plot_interact seems to helped with some tests.
I would suggest squashing merge this, since there are debugging commits.

@alexcjohnson
Copy link
Collaborator

💃 - hope this helps!
This includes #2267 right? If you want to make one squashed PR that supersedes both of these, that's fine by me.

@alexcjohnson alexcjohnson mentioned this pull request Jan 23, 2018
@dy
Copy link
Contributor Author

dy commented Jan 23, 2018

Closed by cb2729e

@dy dy closed this Jan 23, 2018
@dy dy deleted the intermittent-debug branch January 23, 2018 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants