Skip to content

Fix karma tests in windows #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2017
Merged

Fix karma tests in windows #1994

merged 1 commit into from
Sep 8, 2017

Conversation

dy
Copy link
Contributor

@dy dy commented Sep 7, 2017

Otherwise npm run test-jasmine fails with karma-browserify as

07 09 2017 10:43:12.748:ERROR [framework.browserify]: bundle error
07 09 2017 10:43:12.764:ERROR [framework.browserify]: Error: Cannot find module 'C:projectsplotly.js    estimagestrict-d
3.js' from 'C:\projects\plotly.js\test\jasmine\tests'

@dy dy mentioned this pull request Sep 7, 2017
Closed
@etpinard
Copy link
Contributor

etpinard commented Sep 7, 2017

Sweet. Thanks!

💃

@etpinard etpinard merged commit 17237ae into master Sep 8, 2017
@etpinard etpinard deleted the fix-karma branch September 8, 2017 16:19
@alexcjohnson alexcjohnson mentioned this pull request Oct 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dy @etpinard