-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Shared canvases #1993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared canvases #1993
Conversation
Hmm. Looks like a bunch of tests are failing after 8915392. By the looks of it, gl contexts aren't getting cleaned up properly, which makes me concerned about the strategy proposed in #1989. @dfcreative have you tried running |
@etpinard I see that there is only one image diff, that is https://4958-45646037-gh.circle-artifacts.com/0/home/ubuntu/plotly.js/build/test_images_diff/diff-gl3d_mirror-ticks.png, and the diff is in antialias. |
@etpinard now tests pass. Should I create a separate PR for just shared canvases, skipping parcoords changes, or just cherry-pick changes into |
Superseded by #2159 |
Comes after #1989.
Makes use of pre-created 3-canvas strategy, so that no new canvases created.