Skip to content

Add mouse event to plotly_click, plotly_hover and plotly_unhover #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 30, 2017
Merged

Add mouse event to plotly_click, plotly_hover and plotly_unhover #1505

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fe29404
events: plotly_click, plotly_hover, plotly_unhover
n-riesco Mar 15, 2017
a2488a4
events: fix plotly events in geo plots
n-riesco Mar 17, 2017
c56c585
events: fix plotly events in mapbox plots
n-riesco Mar 20, 2017
22a9396
event: fix regression in pie interactions
n-riesco Mar 20, 2017
a95e1c0
events: update tests
n-riesco Mar 15, 2017
b0dbec3
pie: test issue #902
n-riesco Mar 21, 2017
e08f727
pie: emit `plotly_hover` even if hoverinfo is none
n-riesco Mar 21, 2017
0d52abc
pie: test issue #1456
n-riesco Mar 21, 2017
f9e99f9
pie: Fix undefined trace in 'plotly_click'
n-riesco Mar 21, 2017
82f1f7e
events: fix regression in Fx.hover
n-riesco Mar 21, 2017
9a37276
test: add getClientPosition to assets
n-riesco Mar 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plots/cartesian/graph_interact.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ function hover(gd, evt, subplot) {

// [x|y]px: the pixels (from top left) of the mouse location
// on the currently selected plot area
var hasUserCalledHover = ('xpx' in evt || 'ypx' in evt),
var hasUserCalledHover = !evt.target,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which test(s) broke while ('xpx' in evt || 'ypx' in evt)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plotly.js/test/jasmine/tests/hover_label_test.js

Line 35 in 631533d

Fx.hover('graph', evt, 'xy');

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Good to know!

xpx, ypx;

if(hasUserCalledHover) {
Expand Down