Skip to content

Commit 631533d

Browse files
committed
tweak precision to make tests pass on CI w/ Chrome 54
1 parent b86bf06 commit 631533d

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

test/jasmine/tests/annotations_test.js

+5-2
Original file line numberDiff line numberDiff line change
@@ -514,23 +514,26 @@ describe('annotations autorange', function() {
514514

515515
function assertRanges(x, y, x2, y2, x3, y3) {
516516
var fullLayout = gd._fullLayout;
517-
var PREC = 1;
518517

518+
var PREC = 1;
519519
// xaxis2 need a bit more tolerance to pass on CI
520520
// this most likely due to the different text bounding box values
521521
// on headfull vs headless browsers.
522522
// but also because it's a date axis that we've converted to ms
523523
var PRECX2 = -10;
524524
// yaxis2 needs a bit more now too...
525525
var PRECY2 = 0.2;
526+
// and xaxis3 too...
527+
var PRECX3 = 0.2;
528+
526529
var dateAx = fullLayout.xaxis2;
527530

528531
expect(fullLayout.xaxis.range).toBeCloseToArray(x, PREC, '- xaxis');
529532
expect(fullLayout.yaxis.range).toBeCloseToArray(y, PREC, '- yaxis');
530533
expect(Lib.simpleMap(dateAx.range, dateAx.r2l))
531534
.toBeCloseToArray(Lib.simpleMap(x2, dateAx.r2l), PRECX2, 'xaxis2 ' + dateAx.range);
532535
expect(fullLayout.yaxis2.range).toBeCloseToArray(y2, PRECY2, 'yaxis2');
533-
expect(fullLayout.xaxis3.range).toBeCloseToArray(x3, PREC, 'xaxis3');
536+
expect(fullLayout.xaxis3.range).toBeCloseToArray(x3, PRECX3, 'xaxis3');
534537
expect(fullLayout.yaxis3.range).toBeCloseToArray(y3, PREC, 'yaxis3');
535538
}
536539

test/jasmine/tests/hover_label_test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -756,8 +756,8 @@ describe('hover on fill', function() {
756756
var transformParts = hoverText.attr('transform').split('(');
757757
expect(transformParts[0]).toEqual('translate');
758758
var transformCoords = transformParts[1].split(')')[0].split(',');
759-
expect(+transformCoords[0]).toBeCloseTo(labelPos[0], -1, labelText + ':x');
760-
expect(+transformCoords[1]).toBeCloseTo(labelPos[1], -1, labelText + ':y');
759+
expect(+transformCoords[0]).toBeCloseTo(labelPos[0], -1.2, labelText + ':x');
760+
expect(+transformCoords[1]).toBeCloseTo(labelPos[1], -1.2, labelText + ':y');
761761

762762
resolve();
763763
}, constants.HOVERMINTIME);

0 commit comments

Comments
 (0)