Let the regl object tree be garbage collected on Plotly.restyle
#1479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Getting a seemingly unrelated CI failure on this 3 times in a row, mostly the |
monfera
force-pushed
the
gc-regl-context
branch
from
3b9cf9f to
2b788ef
Compare
etpinard
approved these changes
Mar 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having tried more verbose approaches such as keeping around both the
<canvas>element and thereglobject, or just the<canvas>element, the simple and effective route from a memory and object lifecycle point of view was to let the previously createdreglobject be garbage collected. This is achieved by ensuring a fresh<canvas>is created and the previous one gets garbage collected (again, after trying some alternatives), including its attachedglcontext andreglobject.Also, the snapshot making code should no longer remove the canvas as it's not kept around on rerendering.