Skip to content

Commit 9f4823b

Browse files
authored
Merge pull request #1479 from plotly/gc-regl-context
Let the regl object tree be garbage collected on `Plotly.restyle`
2 parents b23fc92 + 2b788ef commit 9f4823b

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/traces/parcoords/base_plot.js

-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ exports.toSVG = function(gd) {
6161
});
6262
}
6363

64-
imageRoot.selectAll('*').remove();
6564
canvases.each(canvasToImage);
6665

6766
// Chrome / Safari bug workaround - browser apparently loses connection to the defined pattern

src/traces/parcoords/parcoords.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -278,11 +278,11 @@ module.exports = function(root, svg, styledData, layout, callbacks) {
278278
.map(model.bind(0, layout))
279279
.map(viewModel);
280280

281+
root.selectAll('.parcoords-line-layers').remove();
282+
281283
var parcoordsLineLayers = root.selectAll('.parcoords-line-layers')
282284
.data(vm, keyFun);
283285

284-
parcoordsLineLayers.exit().remove();
285-
286286
parcoordsLineLayers.enter()
287287
.insert('div', '.' + svg.attr('class').split(' ').join(' .')) // not hardcoding .main-svg
288288
.classed('parcoords-line-layers', true)

0 commit comments

Comments
 (0)