Clone input trace #1136
Closed
Clone input trace #1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Nov 14, 2016
|
|
||
| // make sure traces do not repeat existing ones | ||
| traces = traces.map(function(trace) { | ||
| return Lib.extendFlat({}, trace); |
There was a problem hiding this comment.
@dfcreative Thanks for looking into 🍻 I believe this leads to the desired behaviour. We'll wait for @cpsievert to reply to #1083 (comment) to confirm though.
Do you know exactly why passing existing trace objects to addTraces cause an infinite loop?
There was a problem hiding this comment.
Desired behavior confirmed in #1083 (comment)
etpinard
suggested changes
Nov 14, 2016
|
|
||
| // make sure traces do not repeat existing ones | ||
| traces = traces.map(function(trace) { | ||
| return Lib.extendFlat({}, trace); |
There was a problem hiding this comment.
@dfcreative now that the desired behavior is confirmed. before merging:
TODO
- rewrite
.mapas for-loop. Good old for-loop are apparently much faster than functional calls at least in Chrome. From our latest estimates in https://github.com/plotly/streambed/pull/8395#discussion_r86844172:
- add test case in this suite
There was a problem hiding this comment.
@dfcreative I'd love to get this fix in the next patch release.
Are you available to ✅ the TODO list above today?
If not, no rush, I'll gladly take over this PR.
This was referenced Nov 18, 2016
|
Obsolete by #1175 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1083.
I guess making sure that input trace data for
addTracesis cloned, at least in shallow fashion, is a good move.