Skip to content

Can't layer an existing trace on top of itself #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cpsievert opened this issue Nov 18, 2016 · 6 comments
Closed

Can't layer an existing trace on top of itself #1167

cpsievert opened this issue Nov 18, 2016 · 6 comments
Labels
bug something broken

Comments

@cpsievert
Copy link

http://codepen.io/cpsievert/pen/zoNBMV

Possibly related to #1083. I also tried pushing traces to gd.data and calling Plotly.redraw(gd) with the same problem, so I think the issue needs to be resolved there.

PS. this is quite important for the R packages' newest stuff

@etpinard
Copy link
Contributor

Why don't you just make a clone of that trace in question?

@cpsievert
Copy link
Author

I suppose that would be a smart thing to do 😆

I still find the behavior kind of surprising, but I know u have better things to work on...

PS. would u recommend cloning with var traceClone = JSON.parse(JSON.stringify(trace));?

@etpinard
Copy link
Contributor

@cpsievert I believe a mere flat extend suffice here as @dfcreative 's patch in #1136

JSON.parse + JSON.striginify makes a deep copy which is safer but also very slow.

@etpinard etpinard added the bug something broken label Nov 18, 2016
@etpinard
Copy link
Contributor

Should be resolved in #1136

@etpinard
Copy link
Contributor

fixed in #1175

@etpinard
Copy link
Contributor

Oh and I should mention @cpsievert both this issue and #1083 will be fixed in 1.20.3 set to be released in the next few hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

2 participants