Skip to content

Add identity _fullInput refs to fullTrace #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2016
Merged

Conversation

etpinard
Copy link
Contributor

... so that gd._fullData[i]._fullInput and gd._fullData[i]._expandedTrace are always defined, that is, inside transform traces and non-transforms traces.

This, I believe, will make @VeraZab's live a lot easier for building UI buttons for ohlc and candlestick traces.

@bpostlethwaite can you think of a potential problem here?

@etpinard etpinard added this to the v1.19.0 milestone Oct 24, 2016
@bpostlethwaite
Copy link
Member

So code that only needs to operate on expanded transform traces can do something like self !== self.expandedTrace? I don't know if any of that type of code is in existence though. Not in fits or average yet anyway.

  in non-transformed traces, for consistency with transformed traces
@etpinard
Copy link
Contributor Author

@bpostlethwaite more like:

For example, ohlc trace type, traces in gd.data have type: 'ohlc' and OHLC attributes whereas traces in gd._fullData have type: 'scatter' and scatter attributes. When someone is looking for user-data + defaults (e.g. someone building UI buttons), that person needs to dig into gd._fullData[i]._fullInput - which was previously only defined for transformed traces.

@VeraZab
Copy link

VeraZab commented Oct 25, 2016

The more I dig into our style panel specs, the more I realize that it would indeed really help.

@VeraZab
Copy link

VeraZab commented Oct 25, 2016

💃

@etpinard etpinard merged commit 9468a8c into master Oct 25, 2016
@etpinard etpinard deleted the fulldata-fullinput branch October 25, 2016 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants