Skip to content

Commit 9468a8c

Browse files
authored
Merge pull request #1072 from plotly/fulldata-fullinput
Add identity _fullInput refs to fullTrace
2 parents 297f0a7 + 03f7ef4 commit 9468a8c

File tree

2 files changed

+32
-0
lines changed

2 files changed

+32
-0
lines changed

src/plots/plots.js

+5
Original file line numberDiff line numberDiff line change
@@ -648,6 +648,11 @@ plots.supplyDataDefaults = function(dataIn, dataOut, layout, fullLayout) {
648648
}
649649
}
650650
else {
651+
652+
// add identify refs for consistency with transformed traces
653+
fullTrace._fullInput = fullTrace;
654+
fullTrace._expandedInput = fullTrace;
655+
651656
pushModule(fullTrace);
652657
}
653658
}

test/jasmine/tests/plots_test.js

+27
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,33 @@ describe('Test Plots', function() {
6464
expect(gd._fullLayout.yaxis._m)
6565
.not.toBe(oldFullLayout.yaxis._m, '(set during ax.setScale');
6666
});
67+
68+
it('should include the correct reference to user data', function() {
69+
var trace0 = { y: [1, 2, 3] };
70+
var trace1 = { y: [5, 2, 3] };
71+
72+
var data = [trace0, trace1];
73+
var gd = { data: data };
74+
75+
Plots.supplyDefaults(gd);
76+
77+
expect(gd.data).toBe(data);
78+
79+
expect(gd._fullData[0].index).toEqual(0);
80+
expect(gd._fullData[1].index).toEqual(1);
81+
82+
expect(gd._fullData[0]._expandedIndex).toEqual(0);
83+
expect(gd._fullData[1]._expandedIndex).toEqual(1);
84+
85+
expect(gd._fullData[0]._input).toBe(trace0);
86+
expect(gd._fullData[1]._input).toBe(trace1);
87+
88+
expect(gd._fullData[0]._fullInput).toBe(gd._fullData[0]);
89+
expect(gd._fullData[1]._fullInput).toBe(gd._fullData[1]);
90+
91+
expect(gd._fullData[0]._expandedInput).toBe(gd._fullData[0]);
92+
expect(gd._fullData[1]._expandedInput).toBe(gd._fullData[1]);
93+
});
6794
});
6895

6996
describe('Plots.supplyLayoutGlobalDefaults should', function() {

0 commit comments

Comments
 (0)