Skip to content

ggplotly: separate facet columns by <br> #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2016

Conversation

alyst
Copy link
Contributor

@alyst alyst commented May 23, 2016

Currently ggplotly uses , to separate facet_grid() columns.
The PR changes that to <br> to make it more compatible with ggplot (every column on its own line).
It would also help with overlapping row/column long labels.

@cpsievert
Copy link
Collaborator

Thanks @alyst, this looks promising.

Would you mind bringing this up-to-date with master? With ae6b073, the tests should no longer report false positive test errors, and we can see a more informative test reporter.

It would also be awesome if you could write a test with multiple line breaks to demonstrate the difference!

@alyst
Copy link
Contributor Author

alyst commented Jun 2, 2016

@cpsievert Do you mean PR #471 ? There it's also about line breaks :) I've just rebased that one and updated the "group" tests. I can rebase this PR as well.

@alyst alyst force-pushed the facet_sep_by_br branch from 061cf21 to e027bf1 Compare June 3, 2016 11:52
@cpsievert
Copy link
Collaborator

Thanks! I'm afraid #471 might not get merged. I'm working on a big rewrite locally right now (which will fix this problem) and I'll start a pull request in the next few days.

@cpsievert cpsievert merged commit eab261c into plotly:master Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants