add skip_on_pull_request()

Author: cpsievert

tests/testthat.R

@@ -57,6 +57,17 @@ if (report_diffs || build_table) {
   }
 }
 
+# Some tests make plot.ly HTTP requests and require a valid user account
+# (see test-plotly-filename.R). For security reasons, these tests should be 
+# skipped on pull requests (the .travis.yml file uses encrypted credentials
+# & encrypted environment vars cannot be accessed on pull request builds)
+skip_on_pull_request <- function() {
+  if (!grepl("^[0-9]+$", Sys.getenv("TRAVIS_PULL_REQUEST"))) {
+    return(invisible(TRUE))
+  }
+  skip("Can't test plot.ly API calls on a pull request")
+}
+
 # This function is called within testthat/test-*.R files.
 # It takes a ggplot or plotly object as input, and it returns a figure
 # object (aka the data behind the plot).

tests/testthat/test-plotly-filename.R

@@ -2,6 +2,7 @@ context("Filename")
 
 test_that("filepath with directories is returned as passed", {
   skip_on_cran()
+  skip_on_pull_request()
   p <- plot_ly(mtcars, x = wt, y = vs)
   f <- plotly_POST(p, filename = "directory/awesome")
   expect_match(f$filename, "directory/awesome")

tests/testthat/test-plotly-getfigure.R

@@ -2,27 +2,31 @@ context("get_figure")
 
 test_that("requests made by a user who doesn't exist error a 404", {
   skip_on_cran()
+  skip_on_pull_request()
   expect_error({
     get_figure("klmadslfjdfljdsf", 0)
   }, ".*404.*")
 })
 
 test_that("requests made to retrieve a figure that doesn't exist returns a 404", {
   skip_on_cran()
+  skip_on_pull_request()
   expect_error({
     get_figure("get_test_user", 18324823)
   }, ".*404.*")
 })
 
 test_that("requests made to retrieve some elses private file errors a 403", {
   skip_on_cran()
+  skip_on_pull_request()
   expect_error({
     get_figure("get_test_user", 1)
   }, ".*403.*")
 })
 
 test_that("retrieving a public figure ... works.", {
   skip_on_cran()
+  skip_on_pull_request()
   fig <- get_figure("get_test_user", 0)
   # get the data behind the hash
   p <- plotly_build(fig)
@@ -31,6 +35,7 @@ test_that("retrieving a public figure ... works.", {
 
 test_that("can add traces to a subplot figure", {
   skip_on_cran()
+  skip_on_pull_request()
   fig <- get_figure('chelsea_lyn', 6366)
   p <- add_trace(fig, x=c(1, 2, 3), y=c(4, 2, 4))
   l <- plotly_build(p)
@@ -39,6 +44,7 @@ test_that("can add traces to a subplot figure", {
 
 test_that("posting a hidden plot returns a secret key", {
   skip_on_cran()
+  skip_on_pull_request()
   res <- plotly_POST(plot_ly(), sharing = "secret")
   key <- strsplit(res$url, "=")[[1]][2]
   expect_true(nchar(key) > 1)