Skip to content

Fix bug #47925 again #14348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2024
Merged

Fix bug #47925 again #14348

merged 1 commit into from
May 29, 2024

Conversation

nielsdos
Copy link
Member

The naming of the userland functions is terrible and confused me. gzdecode() is actually the function to decompress a gzip stream, and gzuncompress() is the one to decompress a deflate stream... See zlib.c to see the internal function -> type mapping.

The naming of the userland functions is terrible and confused me.
gzdecode() is actually the function to decompress a gzip stream, and
gzuncompress() is the one to decompress a deflate stream...
See zlib.c to see the internal function -> type mapping.
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol.

LGTM, but perhaps ext/zlib should just expose php_zlib_decode() to avoid going through the entire userland function call shenanigans?

@nielsdos
Copy link
Member Author

LGTM, but perhaps ext/zlib should just expose php_zlib_decode() to avoid going through the entire userland function call shenanigans?

Yes I agree. Can't do that on stable branches unfortunately.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well those are dumb names...

@nielsdos nielsdos merged commit ce7ed6e into php:PHP-8.2 May 29, 2024
8 checks passed
nielsdos added a commit that referenced this pull request May 29, 2024
* PHP-8.2:
  Fix bug #47925 again (#14348)
  Fix GH-14343: Memory leak in xml and dom (#14347)
nielsdos added a commit that referenced this pull request May 29, 2024
* PHP-8.3:
  Fix bug #47925 again (#14348)
  Fix GH-14343: Memory leak in xml and dom (#14347)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants