Fix bug #47925: PHPClient can't decompress response (transposed uncompress methods?)

[nielsdos]

The incorrect functions are being called to deal with incoming compressed data.
gzip/x-gzip corresponds to gzuncompress(), while deflate corresponds to gzinflate().

The existing code for gzip compression also plays with removing the first 10 bytes (i.e. the gzip header) to pass it to the inflate implementation but that doesn't always work properly due to trailer data. Get rid of that entirely by using the correct functions.

[Girgias]

I wonder if it makes sense in the zlib extension to expose those as C functions to prevent a VM re-entry

[nielsdos]

I wonder if it makes sense in the zlib extension to expose those as C functions to prevent a VM re-entry

Probably, not sure if we always use lazy function linking when loading a dso though, I guess we do by default.

[TimWolla]

This PR regressed the following test case:

<?php
$client = new SOAPClient("http://ec.europa.eu/taxation_customs/vies/checkVatService.wsdl", array(
	"features" => SOAP_SINGLE_ELEMENT_ARRAYS,
	"compression" => SOAP_COMPRESSION_ACCEPT | SOAP_COMPRESSION_GZIP | SOAP_COMPRESSION_DEFLATE,
	"exceptions" => true,
	"encoding" => "UTF-8",
));
$response = $client->checkVat(array('countryCode' => 'DE', 'vatNumber' => '811569869'));
var_dump($response);

Before:

object(stdClass)#4 (6) {
  ["countryCode"]=>
  string(2) "DE"
  ["vatNumber"]=>
  string(9) "811569869"
  ["requestDate"]=>
  string(16) "2024-05-28+02:00"
  ["valid"]=>
  bool(true)
  ["name"]=>
  string(3) "---"
  ["address"]=>
  string(3) "---"
}

After:

Warning: gzuncompress(): data error in php-src/test.php on line 8

Fatal error: Uncaught SoapFault exception: [HTTP] Can't uncompress compressed response in php-src/test.php:8
Stack trace:
#0 [internal function]: SoapClient->__doRequest('<?xml version="...', 'http://ec.europ...', '', 1, false)
#1 php-src/test.php(8): SoapClient->__call('checkVat', Array)
#2 {main}
  thrown in php-src/test.php on line 8

[nielsdos]

Fix here: #14348 Thanks for notifying