Skip to content

refactor: Split React components into logical and representational #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2020
Merged

refactor: Split React components into logical and representational #1406

merged 1 commit into from
May 24, 2020

Conversation

bahoss
Copy link
Contributor

@bahoss bahoss commented May 24, 2020 •
edited
Loading

Fix #1405

@bahoss bahoss requested a review from php-coder as a code owner May 24, 2020 04:25
@mystamps-bot
Copy link

mystamps-bot commented May 24, 2020 •
edited
Loading

1 Message
📖 @bahoss thank you for the PR! All quality checks have been passed! Next step is to wait when @php-coder will review this code

Generated by 🚫 Danger

php-coder
php-coder requested changes May 24, 2020
View reviewed changes
Copy link
Owner

@php-coder php-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! You're blazing fast! 🚀

See my comments.

src/main/frontend/src/components/SeriesSaleImportForm.js Outdated
@@ -157,3 +174,4 @@ class SeriesSaleImportForm extends React.PureComponent {
)
}
}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need this change.

@bahoss bahoss force-pushed the Split-React-components-into-logical-and-representational branch 2 times, most recently from 3d89158 to 661709b Compare May 24, 2020 12:36
php-coder
php-coder requested changes May 24, 2020
View reviewed changes
Copy link
Owner

@php-coder php-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple comments.

@bahoss bahoss force-pushed the Split-React-components-into-logical-and-representational branch from 661709b to 52442dd Compare May 24, 2020 14:48
php-coder
php-coder requested changes May 24, 2020
View reviewed changes
Copy link
Owner

@php-coder php-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was ready to merge it but as files contain garbage, I couldn't :(

@bahoss bahoss force-pushed the Split-React-components-into-logical-and-representational branch from 52442dd to 4e2ef06 Compare May 24, 2020 17:42
php-coder
php-coder approved these changes May 24, 2020
View reviewed changes
Copy link
Owner

@php-coder php-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@php-coder php-coder merged commit 4e2ef06 into php-coder:master May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@php-coder php-coder php-coder approved these changes

Assignees
No one assigned
Labels
resolution/merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split React components into logical and representational
3 participants
@bahoss @mystamps-bot @php-coder