You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From each component FooForm, we should extract FooFormView that contains only HTML markup. All the methods and state should remain in FooForm and in its render() method should use <FooFormView />
The text was updated successfully, but these errors were encountered:
@bahoss Hi, could you apply similar changes to other components? Here is the example: d29390e
A few notes:
in *View component, we should extract variable from props in the begging of the render()
don't touch this.props.l10n, leave them as-is (to reduce diff)
when you modify a line and see that it uses foo={something} you can also add a spaces around: foo={ something } (but don't modify existing code just for that)
bahoss
added a commit
to bahoss/mystamps
that referenced
this issue
May 24, 2020
From each component
FooForm
, we should extractFooFormView
that contains only HTML markup. All the methods and state should remain inFooForm
and in itsrender()
method should use<FooFormView />
The text was updated successfully, but these errors were encountered: