Adds support for ansible-lint

[asm0dey]

Fix #479

[mystamps-bot]

	2 Warnings
⚠️	danger check: pull request description doesn’t contain a link to original issue. Consider adding a comment in the following format: Addressed to #XXX where XXX is an issue number
⚠️	danger check: pull request contains 5 commits while most of the cases it should have only one. If it’s not a special case you should squash the commits into single one. But be careful because it can destroy all your changes!

Generated by 🚫 Danger

[php-coder]

Thank you! I have a couple comments.

[php-coder]

Also regarding a commit:

• a commit message must satisfy https://www.conventionalcommits.org requirements (in this case it might look like ci: verify Ansible roles with ansible-lint)
• if it's possible it's better to use "Name Surename" as the author's name instead of a nick name

[php-coder]

I've fixed the description -- this issues is related to #479 and not to #435 Could you update commit message as well?

[asm0dey]

Proof of fail due to ansible-lint: https://travis-ci.org/php-coder/mystamps/jobs/591231907

[php-coder]

Why the build fails with ./src/main/scripts/ci/check-build-and-verify.sh: line 253: ansible-lint: command not found error at this moment?

[php-coder]

Proof of fail due to ansible-lint: https://travis-ci.org/php-coder/mystamps/jobs/591231907

Good to see that it might fail!

Could you suppress this warning to make CI green? It seems like we can add a special comment or something similar -- https://github.com/ansible/ansible-lint#false-positives-skipping-rules

We don't need to fix this issue now as we have a separate issue to deal with it: #998

[php-coder]

Could you suppress this warning to make CI green?

Still here and need to be addressed, otherwise we can't merge this as it will break the builds.

[asm0dey]

I hope I've fixed everything you told me about, please check. After fix into upstream I'm going to fix restic-backups support :)

[php-coder]

In sake of code consistency:

• use [ instead of test
• use single quotes when a string doesn't contain variables

[php-coder]

The original error was:

301 Commands should not change things if nothing needs doing
src/main/scripts/ci/ansible/deploy.yml:37
Task/Handler: Stopping service

I think that we should add a comment to clearly communicate why we suppress this check. Something like this:

301 check is ignored as we always need to stop the service before deploy.

Actually it's a good question -- do we really need to do this always? Perhaps, we could copy WAR file and use handler for restarting the service. I'm not sure whether it's a good approach.

[asm0dey]

I'm almost sure this refactoring should be performed along with bumping ansible version and using systemd module

[php-coder]

Thank you for finding time to update the PR 👍 See my comments.

[php-coder]

P.S. Are you sure that you want to use nickname instead of a full name as an author? I don't insist but need to double check that this is what you want. Typically, people use their names (see git shortlog -s -n for example).

[asm0dey]

@php-coder I definitely prefer to be named by my nickname :)

[php-coder]

Minor improvements only left. Overall looks good, thank you! 👍

BTW could you also amend the first commit (where you added ansible-lint) and append "Fix #479" line? To keep this relation in git history as well.

[php-coder]

@asm0dey I has been thought about merging it as-is now and fix small issue by myself but decided to be with you as pedantic as with others :)

Thank you for patience! I appreciate that!

[php-coder]

@asm0dey I'm happy to merge it finally! Thank you! 🥇

I've also added you to our hall of fame: https://github.com/php-coder/mystamps/wiki/team-members

[asm0dey]

@php-coder Yay! Now let's move to restic improvements :)