Update Ansible to 2.9.2 version #1142

php-coder · 2019-10-22T22:17:42Z

The pinned and outdated version of Ansible brought too much headaches and it seems it's easier to update Ansible rather than continue to put more workarounds.

Also my initial assumption was that it's a regression and but it's turned out that it was actually a fix for buggy behaviour that we use: ansible/ansible#29618

History:

fc72d3b pinning has been introduced
59f05ef it broke our deploy (TravisCI: html5validator and rflint fail to install on prod branch #1020)
ef4abbb it broke our deploy again (Ansible fails to stop monitoring: 'NoneType' object has no attribute 'read' #1089) and I had to apply a workaround

@asm0dey JFYI

The text was updated successfully, but these errors were encountered:

php-coder · 2019-10-22T22:18:50Z

P.S. And now it also conflicts with ansible-lint (see #1129) as it pulls the latest version of Ansible.

php-coder · 2019-10-23T21:16:03Z

One more point: in order to use systemd module (#998) we need Ansible 2.2+

…rent dir. This change makes deployment work on Ansible >2.1.10 See also related issue: ansible/ansible#29618 Prerequisite for #1142

…book. This change makes deployment work on Ansible of the older (>=2.1.10) and newer versions. Correction for 1bf3966 commit. Prerequisite for #1142

php-coder · 2019-11-12T21:01:12Z

I think that we shouldn't unpin but just update to the latest version. Having a fixed version is good for stable builds.

Changelog: https://github.com/ansible/ansible/blob/stable-2.2/CHANGELOG.md Part of #1142

php-coder · 2019-11-13T21:27:25Z

New warnings after update to 2.2.30:

TASK [Stopping service] ********************************************************
 [WARNING]: raw module does not support the environment keyword
changed: [my-stamps.ru]

TASK [Copying WAR file] ********************************************************
changed: [my-stamps.ru]

TASK [Starting service] ********************************************************
 [WARNING]: raw module does not support the environment keyword
changed: [my-stamps.ru]

This was a bug (see ansible/ansible#23764) that has been fixed in newer versions.

php-coder · 2019-11-14T17:20:06Z

TASK [Ensuring that WAR file exists] *******************************************
ok: [my-stamps.ru -> 127.0.0.1] => {
    "changed": false, 
    "msg": "All assertions passed"
}

It seems like we should try quiet parameter to make the output cleaner.

Changelogs: - https://github.com/ansible/ansible/blob/stable-2.3/CHANGELOG.md - https://docs.ansible.com/ansible/latest/porting_guides/porting_guide_2.3.html Part of #1142

Changelogs: - https://github.com/ansible/ansible/blob/stable-2.4/CHANGELOG.md - https://docs.ansible.com/ansible/latest/porting_guides/porting_guide_2.4.html Part of #1142

php-coder · 2019-11-24T17:42:50Z

Warning on 2.9.0 when I run ansible-playbook provisioning/prod.yml -i provisioning/prod.inventory --tags backup:

TASK [mystamps-backup : Creating /data/backups] ************************************************************************************************************************************************************
[DEPRECATION WARNING]: Distribution Ubuntu 16.04 on host my-stamps.ru should use /usr/bin/python3, but is using /usr/bin/python for backward compatibility with prior Ansible releases. A future Ansible
release will default to using the discovered platform python for this host. See https://docs.ansible.com/ansible/2.9/reference_appendices/interpreter_discovery.html for more information. This feature
will be removed in version 2.12. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
ok: [my-stamps.ru]

and

TASK [mystamps-backup : Installing duplicity] **************************************************************************************************************************************************************
[WARNING]: Could not find aptitude. Using apt-get instead

Additional changes have been made: 1) remove get_md5 parameter from stat module. From https://docs.ansible.com/ansible/latest/porting_guides/porting_guide_2.5.html#noteworthy-module-changes % The stat and win_stat modules have changed the default of the option get_md5 from true to false. This option will be removed starting with Ansible version 2.9 % 2) rewrite the way we pass variables to roles. Use "vars" parameter for for that. Inspired by https://docs.ansible.com/ansible/latest/porting_guides/porting_guide_2.5.html#fixed-handling-of-keywords-and-inline-variables 3) migrate "with_items" to "loop" as this is "the recommended way to perform loops". Details: https://docs.ansible.com/ansible/latest/porting_guides/porting_guide_2.5.html#migrating-from-with-x-to-loop Changelogs: - https://github.com/ansible/ansible/blob/stable-2.5/changelogs/CHANGELOG-v2.5.rst - https://docs.ansible.com/ansible/latest/porting_guides/porting_guide_2.5.html Part of #1142

Changelogs: - https://docs.ansible.com/ansible/latest/porting_guides/porting_guide_2.6.html - https://github.com/ansible/ansible/blob/stable-2.6/changelogs/CHANGELOG-v2.6.rst Part of #1142

Changelogs: - https://github.com/ansible/ansible/blob/stable-2.7/changelogs/CHANGELOG-v2.7.rst - https://docs.ansible.com/ansible/latest/porting_guides/porting_guide_2.7.html Part of #1142

Changelogs: - https://github.com/ansible/ansible/blob/stable-2.8/changelogs/CHANGELOG-v2.8.rst - https://docs.ansible.com/ansible/latest/porting_guides/porting_guide_2.8.html Part of #1142

The error was: ERROR! 'quiet' is not a valid attribute for a Task Correction for ab8be0b commit. Address to #1142

php-coder · 2019-12-18T21:06:54Z

It seems like we should try quiet parameter to make the output cleaner.

Done.

New warning after updating to 2.8.x:

TASK [Stopping monitoring] *****************************************************
[DEPRECATION WARNING]: Distribution Ubuntu 16.04 on host my-stamps.ru should
use /usr/bin/python3, but is using /usr/bin/python for backward compatibility
with prior Ansible releases. A future Ansible release will default to using the
discovered platform python for this host. See https://docs.ansible.com/ansible
/2.8/reference_appendices/interpreter_discovery.html for more information. This
feature will be removed in version 2.12. Deprecation warnings can be disabled
by setting deprecation_warnings=False in ansible.cfg.
ok: [my-stamps.ru]

See https://travis-ci.org/php-coder/mystamps/jobs/626895186

Changelogs: - https://docs.ansible.com/ansible/latest/porting_guides/porting_guide_2.9.html - https://github.com/ansible/ansible/blob/stable-2.9/changelogs/CHANGELOG-v2.9.rst Part of #1142

php-coder · 2019-12-28T15:47:37Z

New warning after updating to 2.8.x:

I'll create an issue for that.

php-coder · 2019-12-28T15:56:19Z

Finally fixed in 1ebedcd commit.

/spent 9h36m

Relate to #1142

php-coder added the area/build scripts label Oct 22, 2019

php-coder added this to the 0.4.2 milestone Oct 22, 2019

php-coder self-assigned this Oct 22, 2019

php-coder added the techdebt label Oct 22, 2019

asm0dey mentioned this issue Oct 24, 2019

Implement role testing with molecule #1145

Open

php-coder mentioned this issue Oct 26, 2019

TravisCI: ansible-lint fails to install on prod branch #1148

Closed

php-coder added the kind/dependency-update Update one of dependencies label Nov 6, 2019

php-coder mentioned this issue Nov 9, 2019

Ansible fails to stop monitoring: 'NoneType' object has no attribute 'read' #1089

Open

php-coder added a commit that referenced this issue Nov 10, 2019

ci(deploy.yml): use playbook-relative path instead of rely on the cur…

1bf3966

…rent dir. This change makes deployment work on Ansible >2.1.10 See also related issue: ansible/ansible#29618 Prerequisite for #1142

php-coder changed the title ~~Unpin Ansible and update to the latest version~~ Update Ansible to the latest version Nov 12, 2019

php-coder added a commit that referenced this issue Nov 13, 2019

ci(.travis.yml): update Ansible to 2.2.3.0

af601a4

Changelog: https://github.com/ansible/ansible/blob/stable-2.2/CHANGELOG.md Part of #1142

php-coder added the in progress label Nov 13, 2019

php-coder pinned this issue Nov 17, 2019

php-coder removed the in progress label Dec 2, 2019

php-coder added a commit that referenced this issue Dec 18, 2019

chore(deploy.yml): fix indentation.

f591521

The error was: ERROR! 'quiet' is not a valid attribute for a Task Correction for ab8be0b commit. Address to #1142

php-coder changed the title ~~Update Ansible to the latest version~~ Update Ansible to 2.9.2 version Dec 28, 2019

php-coder closed this as completed Dec 28, 2019

php-coder mentioned this issue Dec 28, 2019

Fix Ansible deprecation warnings #1192

Closed

php-coder unpinned this issue Dec 28, 2019

php-coder added a commit that referenced this issue Dec 28, 2019

chore(deploy.yml): don't try to get a meta info that we don't use.

a27ee65

Relate to #1142

php-coder added the ADR/needed A decision has been made and it needs to be documented label Jan 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Ansible to 2.9.2 version #1142

Update Ansible to 2.9.2 version #1142

php-coder commented Oct 22, 2019 •

edited

Loading

php-coder commented Oct 22, 2019

php-coder commented Oct 23, 2019

php-coder commented Nov 12, 2019 •

edited

Loading

php-coder commented Nov 13, 2019

php-coder commented Nov 14, 2019 •

edited

Loading

php-coder commented Nov 24, 2019

php-coder commented Dec 18, 2019

php-coder commented Dec 28, 2019

php-coder commented Dec 28, 2019

Update Ansible to 2.9.2 version #1142

Update Ansible to 2.9.2 version #1142

Comments

php-coder commented Oct 22, 2019 • edited Loading

php-coder commented Oct 22, 2019

php-coder commented Oct 23, 2019

php-coder commented Nov 12, 2019 • edited Loading

php-coder commented Nov 13, 2019

php-coder commented Nov 14, 2019 • edited Loading

php-coder commented Nov 24, 2019

php-coder commented Dec 18, 2019

php-coder commented Dec 28, 2019

php-coder commented Dec 28, 2019

php-coder commented Oct 22, 2019 •

edited

Loading

php-coder commented Nov 12, 2019 •

edited

Loading

php-coder commented Nov 14, 2019 •

edited

Loading