Search by catalog number in user's collection. #1100

mukeshk · 2019-07-24T09:39:04Z

Addressed to #1098

mystamps-bot · 2019-07-24T09:48:14Z

	1 Warning
⚠️	danger check: pull request description doesn’t contain a link to original issue. Consider adding a comment in the following format: `Addressed to #XXX` where `XXX` is an issue number

Generated by 🚫 Danger

src/main/java/ru/mystamps/web/feature/series/SeriesController.java

mukeshk · 2019-07-24T09:56:50Z

There is no default value, I think I can remove the default value. As the nature of checkbox, they are sent as request param only when checked.

…

On Wed, Jul 24, 2019 at 3:23 PM Slava Semushin ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/main/java/ru/mystamps/web/feature/series/SeriesController.java <#1100 (comment)>: > @@ -504,6 +507,17 @@ public String searchSeriesByCatalog( series = Collections.emptyList(); break; } + + boolean searchInCollection =(inCollection != null)?Boolean.TRUE:Boolean.FALSE; I think that we won't need this, if defaultValue = "false" will work. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1100?email_source=notifications&email_token=AAJPE6C5Y2EAPIOUNZD2F73QBARAJA5CNFSM4IGOERJKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7MX4BI#pullrequestreview-265911813>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJPE6CSS2GEL27SDSUIXZ3QBARAJANCNFSM4IGOERJA> .

mukeshk · 2019-07-24T10:01:48Z

https://github.com/php-coder/mystamps/wiki/checkstyle - I missed it.

php-coder · 2019-07-24T10:01:55Z

There is no default value, I think I can remove the default value.
As the nature of checkbox, they are sent as request param only when checked.

This is attribute of the @RequestParam annotation and it doesn't relate to checkbox at all. It's about parameter that is present in a request or it isn't. In case there is no parameter with such name, the default value is used. So, this is what we need in our case.

php-coder · 2019-07-24T10:03:22Z

https://github.com/php-coder/mystamps/wiki/checkstyle - I missed it.

Better later than never. But anyway, our bot won't let this to pass forward :)

mukeshk · 2019-07-24T10:03:32Z

Aha ! ok - I did a null check. I think your approach is better. Let me try.

…

On Wed, Jul 24, 2019 at 3:31 PM Slava Semushin ***@***.***> wrote: There is no default value, I think I can remove the default value. As the nature of checkbox, they are sent as request param only when checked. This is attribute of the @RequestParam annotation and it doesn't relate to checkbox at all. It's about parameter that is present in a request or it isn't. In case there is no parameter with such name, the default value is used. So, this is what we need in our case. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1100?email_source=notifications&email_token=AAJPE6DXMZWZGKYSIPVBOQTQBASBHA5CNFSM4IGOERJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2V24BA#issuecomment-514567684>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJPE6DXNEFTPVV5FJQXVZLQBASBHANCNFSM4IGOERJA> .

mukeshk · 2019-07-24T10:31:35Z

please review.

src/main/java/ru/mystamps/web/feature/series/SeriesController.java

src/main/webapp/WEB-INF/views/site/index.html

php-coder · 2019-07-24T11:22:48Z

Could you, please, edit the first line of the commit message to be:

task(/series/search/by_catalog): implement the simplest search by catalog number in user's collection.

mukeshk · 2019-07-24T11:46:22Z

Some import series test cases are broken at the moment.
Not sure if it's due to this pull.

php-coder · 2019-07-24T12:30:30Z

Some import series test cases are broken at the moment.

No, it's the test cases. It's from PMD (see also https://github.com/php-coder/mystamps/wiki/pmd-cpd):

[INFO] PMD Failure: ru.mystamps.web.feature.series.SeriesController:474 Rule:AvoidPrefixingMethodParameters Priority:4 Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior..

But don't worry about it -- I'll disable this check from PMD today.

…alog number in user's collection. Part of php-coder#673 Fix php-coder#1098

mukeshk · 2019-07-24T12:54:04Z

Added tab on the line. 479.

php-coder

LGTM. I'll review it and merge tonight.

Thank you!

php-coder · 2019-07-24T13:10:06Z

src/main/java/ru/mystamps/web/feature/series/SeriesController.java

@@ -504,6 +507,18 @@ public String searchSeriesByCatalog(
 				series = Collections.emptyList();
 				break;
 		}
+
+		if (Features.SEARCH_IN_COLLECTION.isActive()


P.S. Could you add a comment before this `if``:

// @todo #1100 Optimize a search within user's collection

Correction, there was a wrong number:

// @todo #1098 Optimize a search within user's collection

I've added it in 742b7d8 commit.

php-coder · 2019-07-24T20:01:10Z

Thank you @mukeshk !

mukeshk requested a review from php-coder as a code owner July 24, 2019 09:39

php-coder reviewed Jul 24, 2019

View reviewed changes

src/main/java/ru/mystamps/web/feature/series/SeriesController.java Outdated Show resolved Hide resolved

php-coder reviewed Jul 24, 2019

View reviewed changes

src/main/java/ru/mystamps/web/feature/series/SeriesController.java Outdated Show resolved Hide resolved

php-coder reviewed Jul 24, 2019

View reviewed changes

src/main/java/ru/mystamps/web/feature/series/SeriesController.java Outdated Show resolved Hide resolved

mukeshk force-pushed the gh1098_search_by_catalog_in_user_collection branch from d8632fa to 81df430 Compare July 24, 2019 09:58

mukeshk force-pushed the gh1098_search_by_catalog_in_user_collection branch 2 times, most recently from c375201 to f8b1081 Compare July 24, 2019 10:29

php-coder reviewed Jul 24, 2019

View reviewed changes

src/main/java/ru/mystamps/web/feature/series/SeriesController.java Outdated Show resolved Hide resolved

php-coder reviewed Jul 24, 2019

View reviewed changes

src/main/java/ru/mystamps/web/feature/series/SeriesController.java Outdated Show resolved Hide resolved

php-coder reviewed Jul 24, 2019

View reviewed changes

src/main/java/ru/mystamps/web/feature/series/SeriesController.java Outdated Show resolved Hide resolved

php-coder reviewed Jul 24, 2019

View reviewed changes

src/main/java/ru/mystamps/web/feature/series/SeriesController.java Outdated Show resolved Hide resolved

php-coder reviewed Jul 24, 2019

View reviewed changes

src/main/webapp/WEB-INF/views/site/index.html Outdated Show resolved Hide resolved

mukeshk force-pushed the gh1098_search_by_catalog_in_user_collection branch 3 times, most recently from e5c6d4e to 41ef557 Compare July 24, 2019 11:22

mukeshk force-pushed the gh1098_search_by_catalog_in_user_collection branch from 41ef557 to a928a87 Compare July 24, 2019 11:24

mukeshk force-pushed the gh1098_search_by_catalog_in_user_collection branch from a928a87 to 04e9319 Compare July 24, 2019 12:37

task(/series/search/by_catalog): implement the simplest search by cat…

c888094

…alog number in user's collection. Part of php-coder#673 Fix php-coder#1098

mukeshk force-pushed the gh1098_search_by_catalog_in_user_collection branch from 04e9319 to c888094 Compare July 24, 2019 12:53

php-coder approved these changes Jul 24, 2019

View reviewed changes

php-coder reviewed Jul 24, 2019

View reviewed changes

php-coder merged commit bee2754 into php-coder:master Jul 24, 2019

php-coder added the resolution/merged label Jul 24, 2019

mukeshk deleted the gh1098_search_by_catalog_in_user_collection branch July 25, 2019 05:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Search by catalog number in user's collection. #1100

Search by catalog number in user's collection. #1100

mukeshk commented Jul 24, 2019 •

edited by php-coder

Loading

mystamps-bot commented Jul 24, 2019 •

edited

Loading

mukeshk commented Jul 24, 2019 via email

mukeshk commented Jul 24, 2019

php-coder commented Jul 24, 2019

php-coder commented Jul 24, 2019

mukeshk commented Jul 24, 2019 via email

mukeshk commented Jul 24, 2019

php-coder commented Jul 24, 2019

mukeshk commented Jul 24, 2019

php-coder commented Jul 24, 2019

mukeshk commented Jul 24, 2019

php-coder left a comment

php-coder Jul 24, 2019

php-coder Jul 24, 2019

php-coder Jul 24, 2019

php-coder commented Jul 24, 2019

Search by catalog number in user's collection. #1100

Search by catalog number in user's collection. #1100

Conversation

mukeshk commented Jul 24, 2019 • edited by php-coder Loading

mystamps-bot commented Jul 24, 2019 • edited Loading

mukeshk commented Jul 24, 2019 via email

mukeshk commented Jul 24, 2019

php-coder commented Jul 24, 2019

php-coder commented Jul 24, 2019

mukeshk commented Jul 24, 2019 via email

mukeshk commented Jul 24, 2019

php-coder commented Jul 24, 2019

mukeshk commented Jul 24, 2019

php-coder commented Jul 24, 2019

mukeshk commented Jul 24, 2019

php-coder left a comment

Choose a reason for hiding this comment

php-coder Jul 24, 2019

Choose a reason for hiding this comment

php-coder Jul 24, 2019

Choose a reason for hiding this comment

php-coder Jul 24, 2019

Choose a reason for hiding this comment

php-coder commented Jul 24, 2019

mukeshk commented Jul 24, 2019 •

edited by php-coder

Loading

mystamps-bot commented Jul 24, 2019 •

edited

Loading