Search by catalog number in user's collection: add the simplest implementation

[php-coder]

Here is the simplest implementation that even doesn't introduce new methods:

• modify SeriesController.searchSeriesByCatalog() method to do the following:
  • after search for series in database (see switch) but right before passing the results to a view (model.addAttribute())
    • if feature is enabled
    • and if checkbox is selected
    • and if a user isn't anonymous
    • iterate over results and filter out the series that a user doesn't have in its collection (use CollectionService.isSeriesInCollection())

Yeah, this is kind of ugly, use extra memory, leads to N+1 query to database but it's fastest approach to implement without adding a lot of code.

This is part of #673

[mukeshk]

I looked at the model SeriesInfoDto which is returned by the repository. We have an Id attribute in there.
This Id attribute needs to be checked against the User Series.

1. How do we know about the Series in a User collection?
2. Did not find CollectionSeries.isSeriesInCollection() method ?

[php-coder]

Did not find CollectionSeries.isSeriesInCollection() method ?

Whoops, I meant CollectionService:

mystamps/src/main/java/ru/mystamps/web/feature/collection/CollectionService.java

Line 30 in f616144

boolean isSeriesInCollection(Integer userId, Integer seriesId);

[php-coder]

How do we know about the Series in a User collection?

CollectionService.isSeriesInCollection() method should help us -- we provide a user and a series and it gives an answer to the question "whether this series in a collection of this user".

[mukeshk]

Ok. This means we need to iterate over records and call the api for each record. Collect the matching elements and send in the response. Do we have a batch API to check the series id? Thanks

…

On Tue 23 Jul, 2019, 2:14 PM Slava Semushin, ***@***.***> wrote: How do we know about the Series in a User collection? CollectionService.isSeriesInCollection() method should help us -- we provide a user and a series and it gives an answer to the question "whether this series in a collection of this user". — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#1098?email_source=notifications&email_token=AAJPE6AW77GPKR3R4WOD6QDQA3AGTA5CNFSM4IF4DKYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2SMIQY#issuecomment-514114627>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJPE6F6J42YUPGQ6UOILH3QA3AGTANCNFSM4IF4DKYA> .

[php-coder]

Ok. This means we need to iterate over records and call the api for each
record. Collect the matching elements and send in the response.

Yes, that's correct.

Do we have a batch API to check the series id?

Not yet. Could be added in one of the iterations later.

At this point, we'll check one by one.

[0pdd]

@php-coder the puzzle #1101 is still not solved.